Program Help!!

This message was edited 2 times. Last update was at 03/12/2006 10:21:01

im really stuck on this, i was given 2classes, a car and garage..i wasnt allowed to change any method or field names i was only allowwed to alter the code in the brackets and i keep gettin errors..the two classes are shown below..can anyone see any problems??..it says "identifier expected<identifier>" for the field in the second class "Garage" called"private ArrayList<Car> cars;"
can anyone help me??..Thanks

// A Garage object tracks a stock of cars for sale and produces reports on sales

import java.util.ArrayList;
public class Garage
{
    // **** Fields needed (5) ****
    
    private String BansalAutomotives;// (1) The name of the garage (to appear in reports)
    private ArrayList<Car> cars;// (2) The stock of cars for sale - this should be an ArrayList" 
    private int[] CarsSold;// (3, 4, 5) Records of the number of cars sold, total sales income and 
    private int[] Income; // total discount for each of the registration years (2001-2005) for which
    private int[] DiscountTotal;// cars are being sold. Each of these fields should be an array.
    
    // **** Constructor ****
    
    public Garage(String garageName)
    {
        BansalAutomotives = garageName;
        cars = new ArrayList<Car>();// Initialisation of ArrayList and array fields needed
        CarsSold = new int[4];
        Income = new int[4];
        DiscountTotal = new int[4]; 
        
    }
    
    
    // Create a new Car with a specified registration and asking price
    // and add the Car to the stock of cars for sale
    // An error is reported if a Car with the specified registration
    // is already in the stock of cars for sale
    public void addCar(String reg, int askingPrice)
    {
        for(Car c: cars){
            if(reg.equals(c.getreg())){
                System.out.println("duplicate RegistrationMark: " + reg);
                
            }
        }
        cars.add(new Car(reg, askingPrice));
    }
       
    // **** Methods ****
    
    // The specified car has been sold for a given amount.
    // The car is removed from the stock of cars for sale.
    // Confirmation of the sale is sent to the output terminal.
    // Information on the sale is recorded, so that a sales report
    // can be produced when required.
    // An error is reported if there is no car with the specified 
    // registration in the stock of cars for sale.
    
    public void sellCar(String reg, int amountSoldFor)
    {
       for (int index = 0; index <cars.size(); index++){
           Car c = cars.get(index);
           if(reg.equals(c.getreg())){
               cars.remove(index);
               System.out.println("Sale Confirmed on Car with Registration: " + reg);
               CarsSold[index]++;
               Income[index]+=amountSoldFor;
               int discount = c.getaskingPrice() - amountSoldFor;
               DiscountTotal[index]+=discount;
            }
        }
        System.out.println("Error Registration " + reg + " cannot find on system");
        
}
    
    
    // The asking price of the specified car is reduced by the given amount.
    // An error is reported if there is no car with the specified 
    // registration in the stock of cars for sale.
    
    public void reducePrice(String reg, int amount)
    {
       for(Car c: cars){
           if(reg.equals(c.getreg())){
               c.changePrice(c.getaskingPrice() - amount);
             
            }
        }
        System.out.println("Error Registration " + reg + " cannot find on system");
}

// A report is printed giving:
    //    - The number of cars sold for each registration year for which 
    //      cars are being sold (2001 - 2005)
    //    - The average price obtained per car for each year (2001 - 2005)
    //    - The average discount given per car for each year (2001 - 2005)
    
    public void printSalesReport()
    {
        System.out.println("year"+"              "+"NUMBER OF CARS SOLD");
        System.out.println("2001"+"              "+ CarsSold[0]);
        System.out.println("2002"+"              "+ CarsSold[1]);
        System.out.println("2003"+"              "+ CarsSold[2]);
        System.out.println("2004"+"              "+ CarsSold[3]);
        System.out.println("2005"+"              "+ CarsSold[4]);
        
}
    
    // A report is printed giving the number of cars in stock and the total
    // value of those cars (the sum of their asking prices)
    
    public void printStockReport()
    {
       System.out.println("$$$$ STOCK REPORT $$$$");
       System.out.println("No. of Cars in Stock: " + cars.size());
       int totalValue = 0;
       for (Car c : cars){
           totalValue += c.getaskingPrice();}
           System.out.println("Total Value of Cars in Stock: " + totalValue);
           totalValue++;
       
    }
    
    
    // **** Coding notes ****
    // 
    // 1) Given a String s, the expression:
    //       Character.digit(s.charAt(k), 10)
    // gives the integer value of the character at position k (counting from 0).
    // This code is needed to get a year (eg 2000 + 3) from a registration
    // String (eg "BX03ABC").
    //
    // 2) Integer arithmetic is accurate enough for calculating the averages 
    // needed for printSalesReport, but take care to avoid division by 0
    // (print ---- rather than a number for such cases).
}

While it doesn't seem like when you first start out, java errors are extremely helpful once you get the hang of them.

Please post the full stack trace, espically the line number. Also, somehow signify the lines affected in your code.

Thanks!

Hmm. I can think of two possible reasons you're getting this error.
1) Car and Garage are not in the same package, and it doesn't recognize Car.
2) You haven't uprgraded to Java 5, and the compiler doesn't recognize the new syntax.

But yes, as tfecw said, please post the full stack trace. Thanks!

ive wrote error where the errror message "identifier expected<identifier>" . its in the second chunk of code at the top in the fields list. i dont know what ive done wrong with the array??..and also i dont understand what you mean by the two classes are not in the same package??..cheers!!

sufs2000 wrote:ive wrote error where the errror message "identifier expected<identifier>" . its in the second chunk of code at the top in the fields list.

Right, but we want to see the whole stack trace.

sufs2000 wrote:i dont understand what you mean by the two classes are not in the same package??..cheers!!

I mean that in one class you might not have access to the other. It's like trying to use ArrayList without importing the java.util package. If the two classes are in the same file you won't get a problem.

oh sorry..lol..i duno what the whole stack trace is??..oh and yea the garage and car class are in the same file..im sure of it..shal i try n make a new file and copy and paste into the new1, would that help??..thnx

Looking back on it, I'm almost positive it's because you haven't upgraded to Java 5. What IDE are you using?